c# - Any solution to Illegal Cross Thread Operation exception?


Translate

When you data bind in C#, the thread that changes the data causes the control to change too. But if this thread is not the one on which the control was created, you'll get an Illegal Cross Thread Operation exception.

Is there anyway to prevent this?


All Answers
  • Translate

    You should be able to do something like:

    if (control.InvokeRequired)
    {
        control.Invoke(delegateWithMyCode);
    }
    else
    {
        delegateWithMyCode();
    }
    

    InvokeRequired is a property on Controls to see if you are on the correct thread, then Invoke will invoke the delegate on the correct thread.

    UPDATE: Actually, at my last job we did something like this:

    private void SomeEventHandler(Object someParam)
    {
        if (this.InvokeRequired)
        {
            this.Invoke(new SomeEventHandlerDelegate(SomeEventHandler), someParam);
        }
    
        // Regular handling code
    }
    

    which removes the need for the else block and kind of tightens up the code.


  • Translate

    As I don't have a test case to go from I can't guarantee this solution, but it seems to me that a scenario similar to the one used to update progress bars in different threads (use a delegate) would be suitable here.

    public delegate void DataBindDelegate();
    public DataBindDelegate BindData = new DataBindDelegate(DoDataBind);
    
    public void DoDataBind()
    {
        DataBind();
    }
    

    If the data binding needs to be done by a particular thread, then let that thread do the work!


  • Translate

    If the thread call is "illegal" (i.e. the DataBind call affects controls that were not created in the thread it is being called from) then you need to create a delegate so that even if the decision / preparation for the DataBind is not done in the control-creating thread, any resultant modification of them (i.e. DataBind()) will be.

    You would call my code from the worker thread like so:

    this.BindData.Invoke();
    

    This would then cause the original thread to do the binding, which (presuming it is the thread that created the controls) should work.


  • Translate

    In WPF and Silverlight the binding infrastructure takes care of the switching to the UI thread.